From 8cb58ef1ebebf719d639b962db9a6139de0c5ce9 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 7 May 2020 08:59:41 +0200 Subject: [PATCH] cli/polkit: add missing variable initialization in retrieve_session_id_cb() Reported by coverity: >>> CID 210213 Uninitialized pointer read (UNINIT) >>> Using uninitialized value iter when calling _nm_auto_free_variant_iter Fixes: df1d214b2ea7 ('clients: polkit-agent: implement polkit agent without using libpolkit') --- clients/common/nm-polkit-listener.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/common/nm-polkit-listener.c b/clients/common/nm-polkit-listener.c index d6361f4bfc..ace205e809 100644 --- a/clients/common/nm-polkit-listener.c +++ b/clients/common/nm-polkit-listener.c @@ -339,7 +339,7 @@ retrieve_session_id_cb (GObject *source_object, NMPolkitListener *listener = NM_POLKIT_LISTENER (user_data); char *session_id; guint32 session_uid; - nm_auto_free_variant_iter GVariantIter *iter; + nm_auto_free_variant_iter GVariantIter *iter = NULL; gs_unref_variant GVariant *ret = NULL; gs_free_error GError *error = NULL; gs_free char *err_str = NULL;