fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-02 13:30:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

dhcp: don't log plain pointer values for debugging

Browse source 
We avoid logging plain pointers. The logfile should not contain pointers
as that theoretically can defeat ASLR.
This commit is contained in:
Thomas Haller 2021-08-05 13:33:27 +02:00
parent 2cbaaed820
commit 8c7ab70915
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core/dhcp/nm-dhcp-nettools.c
View file

@ -1219,7 +1219,7 @@ ip4_start(NMDhcpClient *client, const char *last_ip4_address, GError **error)
return FALSE;
}
_LOGT("dhcp-client4: start %p", (gpointer) priv->client);
_LOGT("dhcp-client4: start " NM_HASH_OBFUSCATE_PTR_FMT, NM_HASH_OBFUSCATE_PTR(priv->client));
nm_dhcp_client_start_timeout(client);
return TRUE;
@ -1233,7 +1233,7 @@ stop(NMDhcpClient *client, gboolean release)
NM_DHCP_CLIENT_CLASS(nm_dhcp_nettools_parent_class)->stop(client, release);
_LOGT("dhcp-client4: stop %p", (gpointer) priv->client);
_LOGT("dhcp-client4: stop " NM_HASH_OBFUSCATE_PTR_FMT, NM_HASH_OBFUSCATE_PTR(priv->client));
priv->probe = n_dhcp4_client_probe_free(priv->probe);
}

2
src/core/dhcp/nm-dhcp-systemd.c
View file

@ -592,7 +592,7 @@ ip4_start(NMDhcpClient *client, const char *last_ip4_address, GError **error)
return FALSE;
}
_LOGT("dhcp-client4: set %p", sd_client);
_LOGT("dhcp-client4: set " NM_HASH_OBFUSCATE_PTR_FMT, NM_HASH_OBFUSCATE_PTR(sd_client));
r = sd_dhcp_client_attach_event(sd_client, NULL, 0);
if (r < 0) {