fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-14 14:30:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

cli/trivial: add comment about partially modifying settings when failing set_fcn()

Browse source
This commit is contained in:
Thomas Haller 2019-03-22 13:45:44 +01:00
parent 7dcf368cf0
commit 8b0461380f
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
clients/common/nm-meta-setting-desc.c
View file

@ -3248,6 +3248,17 @@ _set_fcn_objlist (ARGS_SET_FCN)
}
for (i = 0; i < nstrv; i++) {
/* FIXME: there is the problem here that set_fcn() might succed on the first item
* (modifying it), and fail to parse the second one.
*
* Optimally, we would first parse all input strings before starting the
* modify the setting. The setting should only be modified if (and only if)
* the entire operation succeeds to set all items.
*
* Currently, in interactive mode this leads to odd behavior.
*
* This does not only affect objlist.set_fcn() or _pt_objlist properties.
* E.g. we also call _gobject_property_reset() before validating the input. */
if (!property_info->property_typ_data->subtype.objlist.set_fcn (setting,
!_SET_FCN_DO_REMOVE (modifier, value),
strv[i],