From 8a668d09831899f80ae2cf88d45b370a875ed283 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Sat, 2 Nov 2019 06:55:54 +0100 Subject: [PATCH] iwd: add some missing error handling g_dbus_object_manager_get_interface() can happily return NULL and we need to check for that. (cherry picked from commit 59923ad85d1a1cf2216a4f14649702d24d3f2360) --- src/devices/wifi/nm-iwd-manager.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/devices/wifi/nm-iwd-manager.c b/src/devices/wifi/nm-iwd-manager.c index 5b550ea46d..3151a81261 100644 --- a/src/devices/wifi/nm-iwd-manager.c +++ b/src/devices/wifi/nm-iwd-manager.c @@ -150,6 +150,11 @@ agent_dbus_method_cb (GDBusConnection *connection, network = g_dbus_object_manager_get_interface (priv->object_manager, network_path, NM_IWD_NETWORK_INTERFACE); + if (!network) { + _LOGE ("unable to find the network object"); + return; + } + device_path = get_property_string_or_null (G_DBUS_PROXY (network), "Device"); if (!device_path) { @@ -274,6 +279,11 @@ register_agent (NMIwdManager *self) "/", NM_IWD_AGENT_MANAGER_INTERFACE); + if (!agent_manager) { + _LOGE ("unable to register the IWD Agent: PSK/8021x Wi-Fi networks may not work"); + return; + } + /* Register our agent */ g_dbus_proxy_call (G_DBUS_PROXY (agent_manager), "RegisterAgent",