fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-09 10:00:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm: sort attributes in nm_lldp_neighbor_get_attr_names()

Browse source 
A hash table gives values in undefined order. Sort them, to
get a stable order.
This commit is contained in:
Thomas Haller 2021-03-11 08:26:51 +01:00
parent f8e19f805f
commit 88e22b6832
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/libnm-client-impl/nm-device.c
View file

@ -2963,21 +2963,13 @@ nm_lldp_neighbor_unref(NMLldpNeighbor *neighbor)
char **
nm_lldp_neighbor_get_attr_names(NMLldpNeighbor *neighbor)
{
GHashTableIter iter;
const char * key;
GPtrArray * names;
const char **keys;
g_return_val_if_fail(NM_IS_LLDP_NEIGHBOR(neighbor), NULL);
names = g_ptr_array_new();
keys = nm_utils_strdict_get_keys(neighbor->attrs, TRUE, NULL);
g_hash_table_iter_init(&iter, neighbor->attrs);
while (g_hash_table_iter_next(&iter, (gpointer *) &key, NULL))
g_ptr_array_add(names, g_strdup(key));
g_ptr_array_add(names, NULL);
return (char **) g_ptr_array_free(names, FALSE);
return nm_utils_strv_make_deep_copied_nonnull(keys);
}
/**