fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-04 05:10:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

shared: avoid heap allocation in _nm_utils_enum_from_str_full()

Browse source 
In the vast majority of cases is the string for _nm_utils_enum_from_str_full()
short. As we duplicate it for stripping, prefer to clone it on the stack
with nm_strdup_maybe_a().
This commit is contained in:
Thomas Haller 2021-01-14 17:38:10 +01:00
parent e884ef39ed
commit 88a7ec8b14
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
shared/nm-glib-aux/nm-enum-utils.c
View file

@ -212,8 +212,7 @@ _nm_utils_enum_from_str_full(GType type,
_ASSERT_enum_values_info(type, value_infos);
str_clone = strdup(str);
s = nm_str_skip_leading_spaces(str_clone);
s = nm_strdup_maybe_a(300, nm_str_skip_leading_spaces(str), &str_clone);
g_strchomp(s);
klass = g_type_class_ref(type);