fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-06 23:20:34 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm: emit "notify:name" signal when changing gendata property (NMSettingEthtool)

Browse source 
We want to emit a change notification when gendata-based settings (like
NMSettingEthtool) change. But instead of adding a separate signal, just
emit a fake "notify:name" notification.
This commit is contained in:
Thomas Haller 2019-01-20 14:01:24 +01:00
parent 0b20b44c99
commit 879820ccd5
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
libnm-core/nm-setting.c
View file

@ -1111,6 +1111,8 @@ duplicate_copy_properties (const NMSettInfoSetting *sett_info,
if (sett_info->detail.gendata_info) {
GenData *gendata = _gendata_hash (src, FALSE);
nm_assert (!_gendata_hash (dst, FALSE));
if ( gendata
&& g_hash_table_size (gendata->hash) > 0) {
GHashTableIter iter;
@ -2322,7 +2324,7 @@ _nm_setting_gendata_notify (NMSetting *setting,
gendata = _gendata_hash (setting, FALSE);
if (!gendata)
return;
goto out;
nm_clear_g_free (&gendata->values);
@ -2332,7 +2334,7 @@ _nm_setting_gendata_notify (NMSetting *setting,
nm_clear_g_free (&gendata->names);
}
/* Note, that currently there is now way to notify the subclass when gendata changed.
/* Note, currently there is no way to notify the subclass when gendata changed.
* gendata is only changed in two situations:
* 1) from within NMSetting itself, for example when creating a NMSetting instance
* from keyfile or a D-Bus GVariant.
@ -2345,6 +2347,9 @@ _nm_setting_gendata_notify (NMSetting *setting,
*
* If we ever need it, then we would need to call a virtual function to notify the subclass
* that gendata changed. */
out:
_nm_setting_emit_property_changed (setting);
}
GVariant *
@ -2467,7 +2472,7 @@ nm_setting_gendata_get_all_values (NMSetting *setting)
void
_nm_setting_gendata_to_gvalue (NMSetting *setting,
GValue *value)
GValue *value)
{
GenData *gendata;
GHashTable *new;