From 873d4e89520ff3389ca6e8f37bd81b0b188760a1 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Tue, 26 Mar 2019 14:10:07 +0100 Subject: [PATCH] dns: fix memory leak of error The error was leaked when cancelled. Fixes: 818023c257ca ('dns/resolved: add systemd-resolved backend') (cherry picked from commit 579373a5dfc98b0d39deaf1c12a1b492ac6c4e40) (cherry picked from commit 065fa28373440e1736d715ee8589f4d8e38abba6) --- src/dns/nm-dns-systemd-resolved.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dns/nm-dns-systemd-resolved.c b/src/dns/nm-dns-systemd-resolved.c index 10797b8622..4718e74037 100644 --- a/src/dns/nm-dns-systemd-resolved.c +++ b/src/dns/nm-dns-systemd-resolved.c @@ -122,7 +122,7 @@ static void call_done (GObject *source, GAsyncResult *r, gpointer user_data) { GVariant *v; - GError *error = NULL; + gs_free_error GError *error = NULL; NMDnsSystemdResolved *self = (NMDnsSystemdResolved *) user_data; v = g_dbus_proxy_call_finish (G_DBUS_PROXY (source), r, &error); @@ -130,7 +130,6 @@ call_done (GObject *source, GAsyncResult *r, gpointer user_data) if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) return; _LOGW ("Failed: %s", error->message); - g_error_free (error); } }