From 85da54edd724dd01512dcf65be0b192047c52494 Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Sun, 4 Oct 2009 23:36:06 -0700 Subject: [PATCH] manager: fix use-after-free crash for cdc-ether modems An ethernet device that's actually a component of a modem could get added to the device list, but then destroyed without getting removed from the device list. --- src/nm-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nm-manager.c b/src/nm-manager.c index 416df1ac3e..51a1e693ff 100644 --- a/src/nm-manager.c +++ b/src/nm-manager.c @@ -1203,8 +1203,6 @@ add_device (NMManager *self, NMDevice *device) gpointer value; gboolean managed = FALSE; - priv->devices = g_slist_append (priv->devices, device); - iface = nm_device_get_ip_iface (device); g_assert (iface); @@ -1213,6 +1211,8 @@ add_device (NMManager *self, NMDevice *device) return; } + priv->devices = g_slist_append (priv->devices, device); + g_signal_connect (device, "state-changed", G_CALLBACK (manager_device_state_changed), self);