fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-06 17:50:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg: drop strlen() call from svEscape()

Browse source
This commit is contained in:
Thomas Haller 2017-02-21 15:47:43 +01:00
parent c9f6cb9fe4
commit 8406455b4d
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/settings/plugins/ifcfg-rh/shvar.c
View file

@ -220,14 +220,12 @@ svEscape (const char *s, char **to_free)
int newlen;
size_t i, j, slen;
slen = strlen (s);
for (i = 0; i < slen; i++) {
if (_char_req_escape (s[i]))
for (slen = 0; s[slen]; slen++) {
if (_char_req_escape (s[slen]))
mangle++;
else if (_char_req_quotes (s[i]))
else if (_char_req_quotes (s[slen]))
requires_quotes = TRUE;
else if (s[i] < ' ') {
else if (s[slen] < ' ') {
/* if the string contains newline we can only express it using ANSI C quotation
* (as we don't support line continuation).
* Additionally, ANSI control characters look odd with regular quotation, so handle