From 81d12f020a83b5a7cdbbb9c040f9a4096799480e Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 18 Mar 2020 11:54:07 +0100 Subject: [PATCH] cli: use nm_utils_hwaddr_matches() for matching BSSID in wifi_print_aps() We have a proper implementation for comparing MAC addresses. Don't reimplement it differently. --- clients/cli/devices.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/clients/cli/devices.c b/clients/cli/devices.c index 464cbf3eb7..79183ff26c 100644 --- a/clients/cli/devices.c +++ b/clients/cli/devices.c @@ -2846,14 +2846,13 @@ wifi_print_aps (NMDeviceWifi *wifi, /* Specific AP requested - list only that */ aps = nm_device_wifi_get_access_points (wifi); for (i = 0; i < aps->len; i++) { - char *bssid_up; NMAccessPoint *candidate_ap = g_ptr_array_index (aps, i); - const char *candidate_bssid = nm_access_point_get_bssid (candidate_ap); - bssid_up = g_ascii_strup (bssid_user, -1); - if (!strcmp (bssid_up, candidate_bssid)) + if (nm_utils_hwaddr_matches (bssid_user, + -1, + nm_access_point_get_bssid (candidate_ap), + -1)) ap = candidate_ap; - g_free (bssid_up); } if (ap) { /* Add headers (field names) */