fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-03 14:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

initrd: workaround zero v6 prefixes for NBFT HFIs

Browse source 
Some firmware implementations incorrectly report v6 address prefix
of zero. Let's use /64 as a sane workaround.

Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
This commit is contained in:
Tomas Bzatek 2025-04-02 17:45:33 +02:00 • committed by Beniamino Galvani
parent d38cbfb3d1
commit 81839c0da8
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/nm-initrd-generator/nmi-nbft-reader.c
View file

@ -276,13 +276,17 @@ parse_hfi(GPtrArray *a, struct nbft_info_hfi *hfi, const char *table_name, char
NM_SETTING_IP_CONFIG_METHOD,
NM_SETTING_IP6_CONFIG_METHOD_MANUAL,
NULL);
/* FIXME: buggy firmware implementations may report prefix=0 for v6 addresses,
* reported as https://github.com/timberland-sig/edk2/issues/37
*/
ipaddr = nm_ip_address_new_binary(AF_INET6,
&addr_bin,
hfi->tcp_info.subnet_mask_prefix,
&error);
prefix = hfi->tcp_info.subnet_mask_prefix;
if (prefix == 0) {
/* Buggy firmware implementations may report prefix=0 for v6 addresses,
* let's fall back to /64.
*/
_LOGW(LOGD_CORE,
"NBFT: Invalid IPv6 prefix %d, using /64 as a fallback.",
hfi->tcp_info.subnet_mask_prefix);
prefix = 64;
}
ipaddr = nm_ip_address_new_binary(AF_INET6, &addr_bin, prefix, &error);
if (!ipaddr) {
_LOGW(LOGD_CORE,
"Cannot parse IP %s/%u: %s",