From 8062137cd044940a2ec3d05aa7679f6635e21e5c Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 25 May 2023 21:50:48 +0200 Subject: [PATCH] libnm-base: assert for valid interface name in nm_net_devname_infiniband() --- src/libnm-base/nm-base.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libnm-base/nm-base.c b/src/libnm-base/nm-base.c index c5f9478754..6e164908af 100644 --- a/src/libnm-base/nm-base.c +++ b/src/libnm-base/nm-base.c @@ -63,8 +63,13 @@ nm_net_devname_infiniband(char name[static NM_IFNAMSIZ], const char *parent_name * resilient here, and accept those. */ g_return_val_if_fail(p_key >= 0 && p_key <= 0xffff, NULL); + nm_assert(nm_utils_ifname_valid_kernel(parent_name, NULL)); + /* If parent+suffix is too long, kernel would just truncate * the name. We do the same. See ipoib_vlan_add(). */ g_snprintf(name, NM_IFNAMSIZ, "%s.%04x", parent_name, p_key); + + nm_assert(nm_utils_ifname_valid_kernel(name, NULL)); + return name; }