fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-27 12:50:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/device: demote "strictly unamanged" error

Browse source 
The "device ... not available because device is strictly unmanaged" is
almost certainly the least interesting of the reasons why connection
can't be activated on a device.

Invent a new error level for it and demote it.

Before:

  Error: Connection activation failed: No suitable device found
         for this connection (device lo not available because
         device is strictly unmanaged).

After

  Error: Connection activation failed: No suitable device found
         for this connection (device eth0 not available because
         profile is not compatible with device (...)).

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1433
This commit is contained in:
Lubomir Rintel 2022-10-11 18:28:13 +02:00
parent 59b2ef50e4
commit 7bf46ced2e
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core/devices/nm-device.c
View file

@ -14851,7 +14851,7 @@ _nm_device_check_connection_available(NMDevice *self,
if (!nm_device_get_managed(self, TRUE)) { if (!nm_device_get_managed(self, TRUE)) {
/* device is strictly unmanaged by authoritative unmanaged reasons. */ /* device is strictly unmanaged by authoritative unmanaged reasons. */
nm_utils_error_set_literal(error, nm_utils_error_set_literal(error,
NM_UTILS_ERROR_CONNECTION_AVAILABLE_UNMANAGED_DEVICE, NM_UTILS_ERROR_CONNECTION_AVAILABLE_STRICTLY_UNMANAGED_DEVICE,
"device is strictly unmanaged"); "device is strictly unmanaged");
return FALSE; return FALSE;
} }

1
src/libnm-glib-aux/nm-shared-utils.h
View file

@ -975,6 +975,7 @@ typedef enum {
* message from the device that returned the *highest* error code, * message from the device that returned the *highest* error code,
* in the hope that this message makes the most sense for the caller. * in the hope that this message makes the most sense for the caller.
* */ * */
NM_UTILS_ERROR_CONNECTION_AVAILABLE_STRICTLY_UNMANAGED_DEVICE,
NM_UTILS_ERROR_CONNECTION_AVAILABLE_INCOMPATIBLE, NM_UTILS_ERROR_CONNECTION_AVAILABLE_INCOMPATIBLE,
NM_UTILS_ERROR_CONNECTION_AVAILABLE_UNMANAGED_DEVICE, NM_UTILS_ERROR_CONNECTION_AVAILABLE_UNMANAGED_DEVICE,
NM_UTILS_ERROR_CONNECTION_AVAILABLE_TEMPORARY, NM_UTILS_ERROR_CONNECTION_AVAILABLE_TEMPORARY,