From 7a8b692226ff75c2af0e1fc4bd4e3460ccb61565 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 11 Sep 2018 21:53:04 +0200 Subject: [PATCH] ppp: avoid strncpy() in ppp plugin nm_phasechange() strncpy() is deemed insecure, and it raises at least an eyebrow. While it's save in this case, just avoid it. (cherry picked from commit 4d11eba8c59b6dc00a0cc4b644104b19873699c9) (cherry picked from commit 2f6af40cd5fdd3cd1cf2ba825b9a1e9beccb9381) --- src/ppp/nm-pppd-plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ppp/nm-pppd-plugin.c b/src/ppp/nm-pppd-plugin.c index 989f74339d..0919634006 100644 --- a/src/ppp/nm-pppd-plugin.c +++ b/src/ppp/nm-pppd-plugin.c @@ -147,7 +147,7 @@ nm_phasechange (void *data, int arg) if ( if_indextoname (index, new_name) && !nm_streq0 (ifname, new_name)) { g_message ("nm-ppp-plugin: interface name changed from '%s' to '%s'", ifname, new_name); - strncpy (ifname, new_name, IF_NAMESIZE); + g_strlcpy (ifname, new_name, IF_NAMESIZE); } } }