From 759fbf08de2c9ca60493b1a385368cf79fe6ccba Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 22 Jun 2018 15:36:46 +0200 Subject: [PATCH] wifi/iwd: fix leaking name-owner in agent_dbus_method_cb() (cherry picked from commit 412a1fb46d4257f49b07b6aed262904506777d1e) --- src/devices/wifi/nm-iwd-manager.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/devices/wifi/nm-iwd-manager.c b/src/devices/wifi/nm-iwd-manager.c index 185384dc07..b4047e5b03 100644 --- a/src/devices/wifi/nm-iwd-manager.c +++ b/src/devices/wifi/nm-iwd-manager.c @@ -93,15 +93,16 @@ agent_dbus_method_cb (GDBusConnection *connection, { NMIwdManager *self = user_data; NMIwdManagerPrivate *priv = NM_IWD_MANAGER_GET_PRIVATE (self); - GDBusObjectManagerClient *omc = G_DBUS_OBJECT_MANAGER_CLIENT (priv->object_manager); const gchar *network_path, *device_path, *ifname; gs_unref_object GDBusInterface *network = NULL, *device_obj = NULL; gs_unref_variant GVariant *value = NULL; gint ifindex; NMDevice *device; + gs_free char *name_owner = NULL; /* Be paranoid and check the sender address */ - if (!nm_streq0 (g_dbus_object_manager_client_get_name_owner (omc), sender)) + name_owner = g_dbus_object_manager_client_get_name_owner (G_DBUS_OBJECT_MANAGER_CLIENT (priv->object_manager)); + if (!nm_streq0 (name_owner, sender)) goto return_error; if (!strcmp (method_name, "RequestUserPassword"))