fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-07 23:50:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

manager: avoid wrong ref-counting in do_set_property_check()

Browse source 
Fixes: 52ed6a8e5c
This commit is contained in:
Thomas Haller 2015-09-14 22:22:49 +02:00
parent 4dd0b69a88
commit 757999d484
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/nm-manager.c
View file

@ -4465,23 +4465,27 @@ do_set_property_check (gpointer user_data)
const char *error_message = NULL;
if (!pfd->object) {
pfd->object = nm_bus_manager_get_registered_object (nm_bus_manager_get (),
GObject *object;
object = nm_bus_manager_get_registered_object (nm_bus_manager_get (),
g_dbus_message_get_path (pfd->message));
if (!pfd->object) {
if (!object) {
reply = g_dbus_message_new_method_error (pfd->message,
"org.freedesktop.DBus.Error.UnknownObject",
(error_message = "Object doesn't exist."));
goto out;
}
/* If we lookup the object, we expect the object to be of a certain type.
* Only NMDevice type have settable properties. */
if (!NM_IS_DEVICE (pfd->object)) {
if (!NM_IS_DEVICE (object)) {
reply = g_dbus_message_new_method_error (pfd->message,
"org.freedesktop.DBus.Error.InvalidArgs",
(error_message = "Object is of unexpected type."));
goto out;
}
g_object_ref (pfd->object);
pfd->object = g_object_ref (object);
}
pfd->subject = nm_auth_subject_new_unix_process_from_message (pfd->connection, pfd->message);