From 754b87e1c4fa742959f9c3b52f5c6cac2192fd1b Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Tue, 2 Dec 2025 14:56:20 +0100 Subject: [PATCH] supplicant: separate input and local value We reallocate this value in the function, which is necessary because we write into it, and the input is const. Move the allocation into a local variable instead of overwriting the input pointer, because we are also pointing to it via `char* s`, which is not const. --- src/core/supplicant/nm-supplicant-settings-verify.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/core/supplicant/nm-supplicant-settings-verify.c b/src/core/supplicant/nm-supplicant-settings-verify.c index 6e5e44d2f8..cca53d820f 100644 --- a/src/core/supplicant/nm-supplicant-settings-verify.c +++ b/src/core/supplicant/nm-supplicant-settings-verify.c @@ -212,18 +212,19 @@ validate_type_utf8(const struct Opt *opt, const char *value, const guint32 len) } static gboolean -validate_type_keyword(const struct Opt *opt, const char *value, const guint32 len) +validate_type_keyword(const struct Opt *opt, const char *value_in, const guint32 len) { gs_free char *value_free = NULL; + char *value; nm_assert(opt); - nm_assert(value); + nm_assert(value_in); /* Allow everything */ if (!opt->str_allowed) return TRUE; - value = nm_strndup_a(300, value, len, &value_free); + value = nm_strndup_a(300, value_in, len, &value_free); /* validate each space-separated word in 'value' */