From 72f40fc42153f16758fcdfa704141220d3341547 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 4 Mar 2019 14:24:56 +0100 Subject: [PATCH] clients: fix double free @secrets is unreferenced at the end of request_secrets_from_ui() and so try_spawn_vpn_auth_helper() must take a reference to it. Fixes: 1a0fc8d437b04641b41c86cd1e9a35c48b5b2c67 (cherry picked from commit b57a3a4cc62e3e74c5c0660834449f967236ee17) --- clients/common/nm-secret-agent-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/common/nm-secret-agent-simple.c b/clients/common/nm-secret-agent-simple.c index eeded86151..18be0c6735 100644 --- a/clients/common/nm-secret-agent-simple.c +++ b/clients/common/nm-secret-agent-simple.c @@ -799,7 +799,7 @@ try_spawn_vpn_auth_helper (RequestData *request, .auth_dialog_response = g_string_new_len (NULL, sizeof (data->read_buf)), .auth_dialog_pid = auth_dialog_pid, .request = request, - .secrets = secrets, + .secrets = g_ptr_array_ref (secrets), }; g_output_stream_write_async (auth_dialog_in,