fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-13 06:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

manager: fix very bad usage of 'nm_utils_user_data_unpack'

Browse source 
This results in the args of 'nm_utils_user_data_unpack'
containing random data potentially also from the
previous stack-frame which is really really bad.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
Fixes: b50702775f ('device: implement auth-request as async operation nm_manager_device_auth_request()')
(cherry picked from commit b6a18e0593)
(cherry picked from commit 50adaf7414)
This commit is contained in:
Antonio Cardace 2020-10-22 14:40:15 +02:00 • committed by Thomas Haller
parent 7665d9b29e
commit 72a2e34b42
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/nm-manager.c
View file

@ -2453,7 +2453,14 @@ _device_auth_done_fail_on_idle (gpointer user_data, GCancellable *cancellable)
NMManagerDeviceAuthRequestFunc callback;
gpointer callback_user_data;
nm_utils_user_data_unpack (&self, &device, &context, &subject, &error_original, &callback, &callback_user_data);
nm_utils_user_data_unpack (user_data,
&self,
&device,
&context,
&subject,
&error_original,
&callback,
&callback_user_data);
g_cancellable_set_error_if_cancelled (cancellable, &error_cancelled);