fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 01:47:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm-core: assert that setting's compare_property() is symetric

Browse source
This commit is contained in:
Thomas Haller 2019-10-10 10:20:50 +02:00
parent e36c297fd8
commit 724113c144
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
libnm-core/nm-setting.c
View file

@ -1281,7 +1281,7 @@ _nm_setting_should_compare_secret_property (NMSetting *setting,
}
/* when @setting has the secret-flags that should be ignored,
* we skip the comparisong if:
* we skip the comparison if:
*
* - @other is not present,
* - @other does not have a secret named @secret_name
@ -1393,6 +1393,18 @@ _compare_property (const NMSettInfoSetting *sett_info,
|| NM_FLAGS_HAS (sett_info->property_infos[property_idx].param_spec->flags, NM_SETTING_PARAM_INFERRABLE)
|| compare_result == NM_TERNARY_DEFAULT);
#if NM_MORE_ASSERTS > 10
/* assert that compare_property() is symeric. */
nm_assert ( !set_b
|| compare_result == NM_SETTING_GET_CLASS (set_a)->compare_property (sett_info,
property_idx,
con_b,
set_b,
con_a,
set_a,
flags));
#endif
return compare_result;
}