fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-09 02:28:18 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

nm-manager: restore passing correct size to sendfile in copy_lease()

Browse source 
Otherwise sendfile() fails with EINVAL when the file offset
is greater than zero (pos + size > max), always on the second
iteration.

Fixes: 0c6cd07ec8 ('nm-manager: remove lease file if copying dhclient lease fails')

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/359
This commit is contained in:
Alexey Kodanev 2019-12-11 18:55:07 +03:00 • committed by Thomas Haller
parent f2dbf8fbc0
commit 70ebdc7730
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/nm-manager.c
View file

@ -2700,7 +2700,7 @@ copy_lease (const char *src, const char *dst)
{ {
nm_auto_close int src_fd = -1; nm_auto_close int src_fd = -1;
int dst_fd; int dst_fd;
ssize_t res; ssize_t res, size = SSIZE_MAX;
src_fd = open (src, O_RDONLY|O_CLOEXEC); src_fd = open (src, O_RDONLY|O_CLOEXEC);
if (src_fd < 0) if (src_fd < 0)
@ -2710,8 +2710,8 @@ copy_lease (const char *src, const char *dst)
if (dst_fd < 0) if (dst_fd < 0)
return FALSE; return FALSE;
while ((res = sendfile (dst_fd, src_fd, NULL, G_MAXSSIZE)) > 0) { while ((res = sendfile (dst_fd, src_fd, NULL, size)) > 0)
} size -= res;
nm_close (dst_fd); nm_close (dst_fd);