fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-09 17:00:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg-rh/trivial: add code comment about re-reading connection in writer

Browse source
This commit is contained in:
Thomas Haller 2017-10-23 09:53:18 +02:00
parent 669e693169
commit 7028818a83
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
View file

@ -2958,6 +2958,13 @@ nms_ifcfg_rh_writer_write_connection (NMConnection *connection,
}
}
/* Note that we just wrote the connection to disk, and re-read it from there.
* That is racy if somebody else modifies the connection.
*
* A better solution might be, to re-read the connection only based on the
* in-memory representation of what we collected above. But the reader
* does not yet allow to inject the configuration. */
if (out_reread || out_reread_same) {
gs_unref_object NMConnection *reread = NULL;
gs_free_error GError *local = NULL;