From 6f2b6a674530291d87b93a1da98e87688a8f0a07 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 6 Jun 2014 16:34:57 +0200 Subject: [PATCH] core: fix wrong g_return_if_fail() statement when value should be returned in NMManager:assume_connection() CC nm-manager.lo nm-manager.c: In function 'assume_connection': nm-manager.c:1605:345: error: 'return' with no value, in function returning non-void [-Werror=return-type] g_return_if_fail (nm_device_get_state (device) >= NM_DEVICE_STATE_DISCONNECTED); Minor error, introduced by commit f229f4e201c9b6aefddafcee362b99d2ef6ab40c. Signed-off-by: Thomas Haller --- src/nm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nm-manager.c b/src/nm-manager.c index 681de94ac3..47245b648c 100644 --- a/src/nm-manager.c +++ b/src/nm-manager.c @@ -1602,7 +1602,7 @@ assume_connection (NMManager *self, NMDevice *device, NMConnection *connection) NM_DEVICE_STATE_DISCONNECTED, NM_DEVICE_STATE_REASON_CONNECTION_ASSUMED); } - g_return_if_fail (nm_device_get_state (device) >= NM_DEVICE_STATE_DISCONNECTED); + g_return_val_if_fail (nm_device_get_state (device) >= NM_DEVICE_STATE_DISCONNECTED, FALSE); subject = nm_auth_subject_new_internal (); active = _new_active_connection (self, connection, NULL, device, subject, &error);