fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-02-11 09:30:44 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform/tests: skip test_platform_ip_address_pretty_sort_cmp() on non-amd64 archs

Browse source 
The test only works on amd64, because it relies on the memory layout of
the structures.

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/546
This commit is contained in:
Thomas Haller 2020-10-07 09:08:57 +02:00
parent 3576f54100
commit 6cf7c6739f
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/platform/tests/test-platform-general.c
View file

@ -555,6 +555,20 @@ test_platform_ip_address_pretty_sort_cmp(gconstpointer test_data)
gs_free guint64 *rand_map = NULL;
gsize i, j;
#if !defined(__amd64__)
/* The test generates a random array of NMPlatformIPXAddress (by crudely randomizing the memory,
* not the structures themself) and then compares the sorted result with the expected output.
* The sole purpose is to ensure that the sorting order stays stable.
*
* This only works on an architecture for which the test was made, otherwise
* the expected data does not match (due to different layout of the structures
* in memory).
*
* That's fine. Skip the test. */
g_test_skip("skip test on non-amd64 architecture");
return;
#endif
/*
* First we create a list of addresses filled with (stable) random bytes.
* We tweak some fields explicitly (stable randomly), so that we cover all