From 687051368ffd51381d8e58685a43d3b0f4f945db Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 4 Sep 2023 10:18:23 +0200 Subject: [PATCH] l3cfg: schedule a commit when ACD is not supported On interfaces not supporting ACD (for example, layer3 interfaces), the probe fails to be created with message: l3cfg[...,ifindex=2]: acd[172.25.17.1, init]: probe-good (interface does not support acd, initial post-commit) l3cfg[...,ifindex=2]: acd[172.25.17.1, ready]: set state to ready (probe is ready, waiting for address to be configured) During the post-commit event, if the address is not yet configured, we need to schedule a new commit to actually add it. Fixes: 58287cbcc0c8 ('core: rework IP configuration in NetworkManager using layer 3 configuration') --- src/core/nm-l3cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/nm-l3cfg.c b/src/core/nm-l3cfg.c index ce9d584901..76f4209688 100644 --- a/src/core/nm-l3cfg.c +++ b/src/core/nm-l3cfg.c @@ -2972,8 +2972,7 @@ handle_start_defending: NM_L3_ACD_ADDR_STATE_READY, !NM_IN_SET(state_change_mode, ACD_STATE_CHANGE_MODE_INIT, - ACD_STATE_CHANGE_MODE_INIT_REAPPLY, - ACD_STATE_CHANGE_MODE_POST_COMMIT), + ACD_STATE_CHANGE_MODE_INIT_REAPPLY), "probe is ready, waiting for address to be configured"); } return;