From 641e7177975189929df2ce36c055fe0e660b7fd6 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Mon, 22 Jan 2024 13:53:27 +0100 Subject: [PATCH] libnm-core: fix mac comparison in _remove_mac_blacklist_item_by_value The comparison checking for MAC address equality had previously been flipped around. Fixes: b084ad7f2b0d ('libnm-core: canonicalize hardware addresses in settings') --- src/libnm-core-impl/nm-setting-wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnm-core-impl/nm-setting-wireless.c b/src/libnm-core-impl/nm-setting-wireless.c index 152bbde3d9..244dcdccb7 100644 --- a/src/libnm-core-impl/nm-setting-wireless.c +++ b/src/libnm-core-impl/nm-setting-wireless.c @@ -600,7 +600,7 @@ nm_setting_wireless_remove_mac_blacklist_item_by_value(NMSettingWireless *settin priv = NM_SETTING_WIRELESS_GET_PRIVATE(setting); for (i = 0; i < priv->mac_address_blacklist->len; i++) { candidate = nm_g_array_index(priv->mac_address_blacklist, char *, i); - if (!nm_utils_hwaddr_matches(mac, -1, candidate, -1)) { + if (nm_utils_hwaddr_matches(mac, -1, candidate, -1)) { g_array_remove_index(priv->mac_address_blacklist, i); _notify(setting, PROP_MAC_ADDRESS_BLACKLIST); return TRUE;