fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-09 08:18:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm/trivial: add code comment for _peers_dbus_only_synth() handling of allowed-ips

Browse source
This commit is contained in:
Thomas Haller 2021-04-29 17:27:32 +02:00
parent 12f25d965d
commit 6400c33915
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/libnm-core-impl/nm-setting-wireguard.c
View file

@ -1527,8 +1527,19 @@ _peers_dbus_only_synth(const NMSettInfoSetting * sett_info,
gs_free const char **strv_fixed = NULL; gs_free const char **strv_fixed = NULL;
for (i = 0; i < peer->allowed_ips->len; i++) { for (i = 0; i < peer->allowed_ips->len; i++) {
if (strv[i][0] != ALLOWED_IP_INVALID_X) /* This is a bit odd. The original peer->allowed_ips is a strv array
* of all allowed-ips, but some of them may have an ALLOWED_IP_INVALID_X prefix
* (as first character).
*
* When we serialize the array to GVariant, we need to get rid of this
* character, by pointing to the second character.
*
* In that case, first clone the strv array to strv_fixed. Once we cloned
* it, adjust the pointer to drop the first character. */
if (strv[i][0] != ALLOWED_IP_INVALID_X) {
/* this string is valid, no need for adjustment. */
continue; continue;
}
if (!strv_fixed) { if (!strv_fixed) {
strv_fixed = nm_memdup(strv, sizeof(strv[0]) * peer->allowed_ips->len); strv_fixed = nm_memdup(strv, sizeof(strv[0]) * peer->allowed_ips->len);
strv = strv_fixed; strv = strv_fixed;