From 63e0ed1a086293cb23cd9117f9927f110c785fee Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 7 May 2020 09:37:12 +0200 Subject: [PATCH] libnm: remove early return statement in test_nm_auth_permissions() Reported by coverity: >>> CID 210230: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "i = 0;". Fixes: 09e17888f7f0 ('libnm: add mapping functions between string and NMClientPermission enum') (cherry picked from commit a29b13c7f1eb03cb59ae0cd7bfa5dbd9f027ec84) --- libnm/tests/test-libnm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnm/tests/test-libnm.c b/libnm/tests/test-libnm.c index 90d0cf0d3f..d437c82c6c 100644 --- a/libnm/tests/test-libnm.c +++ b/libnm/tests/test-libnm.c @@ -3103,7 +3103,7 @@ test_nm_auth_permissions (void) g_assert (s == nm_auth_permission_names_by_idx[i - 1]); g_assert_cmpint (nm_auth_permission_from_string (s), ==, i); } - return; + for (i = 0; i < NM_CLIENT_PERMISSION_LAST; i++) g_assert_cmpint (nm_auth_permission_from_string (nm_auth_permission_names_by_idx[i]), ==, i + 1); }