From 86e99fca6bf7bba564365e94b8b904edd650207a Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 12 May 2021 18:50:45 +0200 Subject: [PATCH 1/4] examples: avoid deprecated PropertiesChanged signal in "create-bond.py" example --- examples/python/dbus/create-bond.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/examples/python/dbus/create-bond.py b/examples/python/dbus/create-bond.py index 4ebec24a6c..fe35fcc0ba 100755 --- a/examples/python/dbus/create-bond.py +++ b/examples/python/dbus/create-bond.py @@ -40,8 +40,8 @@ def create_bond(bond_name): "autoconnect-slaves": 1, } ) - s_ip4 = dbus.Dictionary({"method": "auto"}) - s_ip6 = dbus.Dictionary({"method": "ignore"}) + s_ip4 = dbus.Dictionary({"method": "disabled"}) + s_ip6 = dbus.Dictionary({"method": "disabled"}) con = dbus.Dictionary( {"bond": s_bond, "connection": s_con, "ipv4": s_ip4, "ipv6": s_ip6} @@ -97,18 +97,22 @@ print("Activating bond: %s (%s)" % (bond_name, ac)) loop = GLib.MainLoop() -def properties_changed(props): - if "State" in props: - if props["State"] == 2: +def properties_changed(interface_name, changed_properties, invalidated_properties): + if ( + interface_name == "org.freedesktop.NetworkManager.Connection.Active" + and "State" in changed_properties + ): + state = changed_properties["State"] + if state == 2: print("Successfully connected") loop.quit() - if props["State"] == 3 or props["State"] == 4: + if state == 3 or state == 4: print("Bond activation failed") loop.quit() obj = bus.get_object("org.freedesktop.NetworkManager", ac) -iface = dbus.Interface(obj, "org.freedesktop.NetworkManager.Connection.Active") +iface = dbus.Interface(obj, "org.freedesktop.DBus.Properties") iface.connect_to_signal("PropertiesChanged", properties_changed) loop.run() From c8900a437ab80457308b3d5a72932feff6edac4f Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 12 May 2021 22:22:49 +0200 Subject: [PATCH 2/4] core: use define DBUS_INTERFACE_PROPERTIES instead of string literal --- src/core/nm-dbus-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/nm-dbus-manager.c b/src/core/nm-dbus-manager.c index 7c1e4eab18..95e403ae4d 100644 --- a/src/core/nm-dbus-manager.c +++ b/src/core/nm-dbus-manager.c @@ -1233,7 +1233,7 @@ _nm_dbus_manager_obj_notify(NMDBusObject *obj, guint n_pspecs, const GParamSpec priv->main_dbus_connection, NULL, obj->internal.path, - "org.freedesktop.DBus.Properties", + DBUS_INTERFACE_PROPERTIES, "PropertiesChanged", g_variant_new("(s@a{sv}as)", interface_info->parent.name, args, &invalidated_builder), NULL); From 48dce1b66ce3910a81abc8595acb79d8516a9f1c Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 12 May 2021 18:18:57 +0200 Subject: [PATCH 3/4] core: drop deprecated PropertiesChanged D-Bus signal (API BREAK) D-Bus 1.3.1 (2010) introduced the standard "PropertiesChanged" signal on "org.freedesktop.DBus.Properties". NetworkManager is old, and predates this API. From that time, it still had it's own PropertiesChanged signal that are emitted together with the standard ones. NetworkManager supports the standard PropertiesChanged signal since it switched to gdbus library in version 1.2.0 (2016). These own signals are deprecated for a long time already ([1], 2016), and are hopefully not used by anybody anymore. libnm-glib was using them and relied on them, but that library is gone. libnm does not use them and neither does plasma-nm. Hopefully no users are left that are affected by this API break. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commits/6fb917178aa19c61e909957f5146aa4565e0cb2f --- NEWS | 3 + ...freedesktop.NetworkManager.AccessPoint.xml | 9 -- ...reedesktop.NetworkManager.AgentManager.xml | 1 + ....freedesktop.NetworkManager.Checkpoint.xml | 9 -- ...sktop.NetworkManager.Connection.Active.xml | 9 -- ...freedesktop.NetworkManager.DHCP4Config.xml | 9 -- ...freedesktop.NetworkManager.DHCP6Config.xml | 10 -- ...freedesktop.NetworkManager.Device.Adsl.xml | 11 +- ...esktop.NetworkManager.Device.Bluetooth.xml | 9 -- ...freedesktop.NetworkManager.Device.Bond.xml | 9 -- ...eedesktop.NetworkManager.Device.Bridge.xml | 9 -- ...reedesktop.NetworkManager.Device.Dummy.xml | 9 -- ...edesktop.NetworkManager.Device.Generic.xml | 9 -- ...desktop.NetworkManager.Device.IPTunnel.xml | 9 -- ...sktop.NetworkManager.Device.Infiniband.xml | 9 -- ...eedesktop.NetworkManager.Device.Lowpan.xml | 1 + ...eedesktop.NetworkManager.Device.Macsec.xml | 9 -- ...edesktop.NetworkManager.Device.Macvlan.xml | 9 -- ...reedesktop.NetworkManager.Device.Modem.xml | 10 -- ...desktop.NetworkManager.Device.OlpcMesh.xml | 9 -- ...esktop.NetworkManager.Device.OvsBridge.xml | 9 -- ...top.NetworkManager.Device.OvsInterface.xml | 9 -- ...edesktop.NetworkManager.Device.OvsPort.xml | 9 -- ....freedesktop.NetworkManager.Device.Ppp.xml | 9 -- ...sktop.NetworkManager.Device.Statistics.xml | 9 -- ...freedesktop.NetworkManager.Device.Team.xml | 9 -- ....freedesktop.NetworkManager.Device.Tun.xml | 9 -- ...freedesktop.NetworkManager.Device.Veth.xml | 9 -- ...freedesktop.NetworkManager.Device.Vlan.xml | 9 -- ....freedesktop.NetworkManager.Device.Vrf.xml | 1 + ...reedesktop.NetworkManager.Device.Vxlan.xml | 9 -- ...reedesktop.NetworkManager.Device.WiMax.xml | 11 +- ...esktop.NetworkManager.Device.WireGuard.xml | 1 + ...reedesktop.NetworkManager.Device.Wired.xml | 9 -- ...desktop.NetworkManager.Device.Wireless.xml | 13 +- .../org.freedesktop.NetworkManager.Device.xml | 1 + ...g.freedesktop.NetworkManager.IP4Config.xml | 9 -- ...g.freedesktop.NetworkManager.IP6Config.xml | 9 -- ...freedesktop.NetworkManager.SecretAgent.xml | 1 + ...top.NetworkManager.Settings.Connection.xml | 9 -- ...rg.freedesktop.NetworkManager.Settings.xml | 11 +- ...edesktop.NetworkManager.VPN.Connection.xml | 11 +- ....freedesktop.NetworkManager.VPN.Plugin.xml | 1 + ...g.freedesktop.NetworkManager.WiMax.Nsp.xml | 9 -- ...freedesktop.NetworkManager.WifiP2PPeer.xml | 1 + .../org.freedesktop.NetworkManager.xml | 11 +- src/core/devices/adsl/nm-device-adsl.c | 6 +- src/core/devices/bluetooth/nm-device-bt.c | 14 +- src/core/devices/nm-device-bond.c | 12 +- src/core/devices/nm-device-bridge.c | 12 +- src/core/devices/nm-device-dummy.c | 8 +- src/core/devices/nm-device-ethernet.c | 26 ++-- src/core/devices/nm-device-generic.c | 8 +- src/core/devices/nm-device-infiniband.c | 10 +- src/core/devices/nm-device-ip-tunnel.c | 58 ++++---- src/core/devices/nm-device-macsec.c | 62 ++++---- src/core/devices/nm-device-macvlan.c | 16 +- src/core/devices/nm-device-ppp.c | 5 +- src/core/devices/nm-device-tun.c | 26 ++-- src/core/devices/nm-device-veth.c | 6 +- src/core/devices/nm-device-vlan.c | 14 +- src/core/devices/nm-device-vxlan.c | 58 ++++---- src/core/devices/nm-device.c | 137 +++++++++--------- src/core/devices/ovs/nm-device-ovs-bridge.c | 4 +- .../devices/ovs/nm-device-ovs-interface.c | 5 +- src/core/devices/ovs/nm-device-ovs-port.c | 4 +- src/core/devices/team/nm-device-team.c | 16 +- src/core/devices/wifi/nm-device-olpc-mesh.c | 14 +- src/core/devices/wifi/nm-device-wifi-p2p.c | 1 - src/core/devices/wifi/nm-wifi-ap.c | 34 ++--- src/core/devices/wifi/nm-wifi-common.c | 38 ++--- src/core/devices/wifi/nm-wifi-p2p-peer.c | 1 - src/core/devices/wwan/nm-device-modem.c | 14 +- src/core/dns/nm-dns-manager.c | 14 +- src/core/nm-active-connection.c | 88 ++++++----- src/core/nm-checkpoint.c | 14 +- src/core/nm-dbus-manager.c | 81 ----------- src/core/nm-dbus-object.h | 11 -- src/core/nm-dbus-utils.c | 4 - src/core/nm-dbus-utils.h | 118 ++++----------- src/core/nm-dhcp-config.c | 16 +- src/core/nm-ip4-config.c | 58 ++++---- src/core/nm-ip6-config.c | 56 ++++--- src/core/nm-manager.c | 103 +++++++------ src/core/settings/nm-settings-connection.c | 11 +- src/core/settings/nm-settings.c | 18 +-- src/core/vpn/nm-vpn-connection.c | 16 +- 87 files changed, 477 insertions(+), 1100 deletions(-) diff --git a/NEWS b/NEWS index 62e9abd072..b494cb7258 100644 --- a/NEWS +++ b/NEWS @@ -16,6 +16,9 @@ USE AT YOUR OWN RISK. NOT RECOMMENDED FOR PRODUCTION USE! * Enforce valid "connection.uuid" by normalizing the string to lower case. This changes the UUID of existing profiles that had an invalid, non-normalized value. +* API BREAK: D-Bus: remove long deprecated PropertiesChanged signal from D-Bus + API. They are replaced by standard PropertiesChanged signal on the + "org.freedesktop.DBus.Properties" interface. ============================================= NetworkManager-1.30 diff --git a/introspection/org.freedesktop.NetworkManager.AccessPoint.xml b/introspection/org.freedesktop.NetworkManager.AccessPoint.xml index 769ab7a935..6edb25ead2 100644 --- a/introspection/org.freedesktop.NetworkManager.AccessPoint.xml +++ b/introspection/org.freedesktop.NetworkManager.AccessPoint.xml @@ -95,14 +95,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.AgentManager.xml b/introspection/org.freedesktop.NetworkManager.AgentManager.xml index e8df4872af..e5fbd100ec 100644 --- a/introspection/org.freedesktop.NetworkManager.AgentManager.xml +++ b/introspection/org.freedesktop.NetworkManager.AgentManager.xml @@ -38,5 +38,6 @@ when they disconnect from D-Bus. --> + diff --git a/introspection/org.freedesktop.NetworkManager.Checkpoint.xml b/introspection/org.freedesktop.NetworkManager.Checkpoint.xml index daab0c903b..1496ed4ea4 100644 --- a/introspection/org.freedesktop.NetworkManager.Checkpoint.xml +++ b/introspection/org.freedesktop.NetworkManager.Checkpoint.xml @@ -32,14 +32,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Connection.Active.xml b/introspection/org.freedesktop.NetworkManager.Connection.Active.xml index 3962cf88ee..54e1fd9445 100644 --- a/introspection/org.freedesktop.NetworkManager.Connection.Active.xml +++ b/introspection/org.freedesktop.NetworkManager.Connection.Active.xml @@ -169,14 +169,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.DHCP4Config.xml b/introspection/org.freedesktop.NetworkManager.DHCP4Config.xml index 2e0ae82e10..0da12d62d0 100644 --- a/introspection/org.freedesktop.NetworkManager.DHCP4Config.xml +++ b/introspection/org.freedesktop.NetworkManager.DHCP4Config.xml @@ -17,14 +17,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.DHCP6Config.xml b/introspection/org.freedesktop.NetworkManager.DHCP6Config.xml index 0f064c4c87..940cf4e463 100644 --- a/introspection/org.freedesktop.NetworkManager.DHCP6Config.xml +++ b/introspection/org.freedesktop.NetworkManager.DHCP6Config.xml @@ -16,15 +16,5 @@ Configuration options returned by a DHCP server, if any. --> - - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Adsl.xml b/introspection/org.freedesktop.NetworkManager.Device.Adsl.xml index 5bb18aae12..29701d7874 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Adsl.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Adsl.xml @@ -7,16 +7,6 @@ --> - - - - - + diff --git a/introspection/org.freedesktop.NetworkManager.Device.Bluetooth.xml b/introspection/org.freedesktop.NetworkManager.Device.Bluetooth.xml index 1f5e618975..5cd0eaaee1 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Bluetooth.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Bluetooth.xml @@ -32,14 +32,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Bond.xml b/introspection/org.freedesktop.NetworkManager.Device.Bond.xml index c7ccf38998..26611aae59 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Bond.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Bond.xml @@ -35,14 +35,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml b/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml index 5a35f54dd1..379e702a47 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Bridge.xml @@ -35,14 +35,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Dummy.xml b/introspection/org.freedesktop.NetworkManager.Device.Dummy.xml index 2c5675e8ae..22c917e831 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Dummy.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Dummy.xml @@ -16,14 +16,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Generic.xml b/introspection/org.freedesktop.NetworkManager.Device.Generic.xml index b847018be4..792c460bab 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Generic.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Generic.xml @@ -23,14 +23,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.IPTunnel.xml b/introspection/org.freedesktop.NetworkManager.Device.IPTunnel.xml index 7c464b9478..4d8a85bbc6 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.IPTunnel.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.IPTunnel.xml @@ -95,14 +95,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml b/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml index 53f71486df..e931a95820 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Infiniband.xml @@ -27,14 +27,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Lowpan.xml b/introspection/org.freedesktop.NetworkManager.Device.Lowpan.xml index 3415f18510..3866946d32 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Lowpan.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Lowpan.xml @@ -22,5 +22,6 @@ The object path of the parent device. --> + diff --git a/introspection/org.freedesktop.NetworkManager.Device.Macsec.xml b/introspection/org.freedesktop.NetworkManager.Device.Macsec.xml index 0f109c1d6c..6fd2cee54d 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Macsec.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Macsec.xml @@ -105,14 +105,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Macvlan.xml b/introspection/org.freedesktop.NetworkManager.Device.Macvlan.xml index 3370ab04d6..cd810a53ca 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Macvlan.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Macvlan.xml @@ -35,14 +35,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Modem.xml b/introspection/org.freedesktop.NetworkManager.Device.Modem.xml index fabe1a2ee0..b089bda2de 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Modem.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Modem.xml @@ -58,15 +58,5 @@ --> - - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.OlpcMesh.xml b/introspection/org.freedesktop.NetworkManager.Device.OlpcMesh.xml index 3ae7ea961d..040a6a5d86 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.OlpcMesh.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.OlpcMesh.xml @@ -30,14 +30,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.OvsBridge.xml b/introspection/org.freedesktop.NetworkManager.Device.OvsBridge.xml index 402ee028b3..ff58bd9527 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.OvsBridge.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.OvsBridge.xml @@ -17,14 +17,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.OvsInterface.xml b/introspection/org.freedesktop.NetworkManager.Device.OvsInterface.xml index 9605a958b4..be64eb471c 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.OvsInterface.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.OvsInterface.xml @@ -7,14 +7,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.OvsPort.xml b/introspection/org.freedesktop.NetworkManager.Device.OvsPort.xml index c2db70ffd1..b43080378e 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.OvsPort.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.OvsPort.xml @@ -17,14 +17,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Ppp.xml b/introspection/org.freedesktop.NetworkManager.Device.Ppp.xml index 00605f7219..0032692e68 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Ppp.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Ppp.xml @@ -7,14 +7,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Statistics.xml b/introspection/org.freedesktop.NetworkManager.Device.Statistics.xml index 39230b7fd0..06781692b4 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Statistics.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Statistics.xml @@ -31,14 +31,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Team.xml b/introspection/org.freedesktop.NetworkManager.Device.Team.xml index 0a4c72122d..bbae316b1d 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Team.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Team.xml @@ -42,14 +42,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Tun.xml b/introspection/org.freedesktop.NetworkManager.Device.Tun.xml index 97bf5848cd..55a9bacb8d 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Tun.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Tun.xml @@ -61,14 +61,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Veth.xml b/introspection/org.freedesktop.NetworkManager.Device.Veth.xml index a5265e074e..900554c428 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Veth.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Veth.xml @@ -14,14 +14,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml b/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml index b63194ec66..1ab762b2b7 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Vlan.xml @@ -41,14 +41,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Vrf.xml b/introspection/org.freedesktop.NetworkManager.Device.Vrf.xml index 971d2b619d..9dfb6c8740 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Vrf.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Vrf.xml @@ -13,5 +13,6 @@ The routing table of the VRF. --> + diff --git a/introspection/org.freedesktop.NetworkManager.Device.Vxlan.xml b/introspection/org.freedesktop.NetworkManager.Device.Vxlan.xml index 035ca09b94..4c04f9dfb6 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Vxlan.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Vxlan.xml @@ -135,14 +135,5 @@ n --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.WiMax.xml b/introspection/org.freedesktop.NetworkManager.Device.WiMax.xml index 532b696432..e510a142db 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.WiMax.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.WiMax.xml @@ -85,16 +85,6 @@ --> - - - - - + diff --git a/introspection/org.freedesktop.NetworkManager.Device.Wired.xml b/introspection/org.freedesktop.NetworkManager.Device.Wired.xml index c501091951..ec3aeae37e 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Wired.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Wired.xml @@ -49,14 +49,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml b/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml index c043a2c2f7..c57e568988 100644 --- a/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml +++ b/introspection/org.freedesktop.NetworkManager.Device.Wireless.xml @@ -108,16 +108,6 @@ --> - - - - - - + - - - - diff --git a/introspection/org.freedesktop.NetworkManager.IP6Config.xml b/introspection/org.freedesktop.NetworkManager.IP6Config.xml index d2859b5af5..3fe4a46836 100644 --- a/introspection/org.freedesktop.NetworkManager.IP6Config.xml +++ b/introspection/org.freedesktop.NetworkManager.IP6Config.xml @@ -88,14 +88,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.SecretAgent.xml b/introspection/org.freedesktop.NetworkManager.SecretAgent.xml index 654b3f2f05..7c96064bc6 100644 --- a/introspection/org.freedesktop.NetworkManager.SecretAgent.xml +++ b/introspection/org.freedesktop.NetworkManager.SecretAgent.xml @@ -89,5 +89,6 @@ + diff --git a/introspection/org.freedesktop.NetworkManager.Settings.Connection.xml b/introspection/org.freedesktop.NetworkManager.Settings.Connection.xml index 40829e252d..55bdaff669 100644 --- a/introspection/org.freedesktop.NetworkManager.Settings.Connection.xml +++ b/introspection/org.freedesktop.NetworkManager.Settings.Connection.xml @@ -186,14 +186,5 @@ --> - - - - diff --git a/introspection/org.freedesktop.NetworkManager.Settings.xml b/introspection/org.freedesktop.NetworkManager.Settings.xml index 1544e5529b..28c89ff4f7 100644 --- a/introspection/org.freedesktop.NetworkManager.Settings.xml +++ b/introspection/org.freedesktop.NetworkManager.Settings.xml @@ -159,16 +159,6 @@ --> - - - - - - - - - - - - - diff --git a/introspection/org.freedesktop.NetworkManager.WifiP2PPeer.xml b/introspection/org.freedesktop.NetworkManager.WifiP2PPeer.xml index 9bbba3b834..760849c3f0 100644 --- a/introspection/org.freedesktop.NetworkManager.WifiP2PPeer.xml +++ b/introspection/org.freedesktop.NetworkManager.WifiP2PPeer.xml @@ -107,5 +107,6 @@ Since: 1.16 --> + diff --git a/introspection/org.freedesktop.NetworkManager.xml b/introspection/org.freedesktop.NetworkManager.xml index 2bcb156eec..ff74c5122d 100644 --- a/introspection/org.freedesktop.NetworkManager.xml +++ b/introspection/org.freedesktop.NetworkManager.xml @@ -549,16 +549,6 @@ --> - - - - -