From 63664719bee096a350b4633fd6ba20c8a0377155 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 9 Mar 2022 23:14:24 +0100 Subject: [PATCH] core/dhcp: use gs_free_error in NMDhcpDhcpcd's ip4_start() It just seems less error prone. Use the cleanup attribute. --- src/core/dhcp/nm-dhcp-dhcpcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/dhcp/nm-dhcp-dhcpcd.c b/src/core/dhcp/nm-dhcp-dhcpcd.c index 4b3429ef67..280d9ce6d1 100644 --- a/src/core/dhcp/nm-dhcp-dhcpcd.c +++ b/src/core/dhcp/nm-dhcp-dhcpcd.c @@ -70,7 +70,7 @@ ip4_start(NMDhcpClient *client, GError **error) const NMDhcpClientConfig *client_config; gs_unref_ptrarray GPtrArray *argv = NULL; pid_t pid; - GError *local = NULL; + gs_free_error GError *local = NULL; gs_free char *cmd_str = NULL; const char *dhcpcd_path; @@ -143,7 +143,6 @@ ip4_start(NMDhcpClient *client, GError **error) NM_UTILS_ERROR_UNKNOWN, "dhcpcd failed to start: %s", local->message); - g_error_free(local); return FALSE; }