From 6281e328752d8793033e2ce594e831c7a94bcbdb Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 18 Jun 2020 08:49:15 +0200 Subject: [PATCH] cli: fix reference count handling in hotspot error path The connection is automatically unreferenced when the function returns. Fixes: 9c5ea0917d51 ('devices: reuse the hotspot connection if we find appropriate one'): (cherry picked from commit 3ecfd13dedb1260968e07b49423017e7bf328200) (cherry picked from commit 26f1074d9dec4172933f0e9be58b9a270f6ef4b2) --- clients/cli/devices.c | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/cli/devices.c b/clients/cli/devices.c index d5224b9301..1f8d0e4215 100644 --- a/clients/cli/devices.c +++ b/clients/cli/devices.c @@ -4174,7 +4174,6 @@ do_device_wifi_hotspot (const NMCCommand *cmd, NmCli *nmc, int argc, const char g_return_if_fail (s_wsec); if (!set_wireless_security_for_hotspot (s_wsec, wifi_mode, caps, password, show_password, &error)) { - g_object_unref (connection); g_string_printf (nmc->return_text, _("Error: Invalid 'password': %s."), error->message); g_clear_error (&error); nmc->return_value = NMC_RESULT_ERROR_UNKNOWN;