From 623f8a2be17aa90fb276229dbfa5be5815dae317 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 30 Oct 2013 13:33:32 +0100 Subject: [PATCH] cli: fix bash completion for `nmcli connection modify` Only complete the setting name if it is at the very first position after the connection. e.g. complete the settings name in the case $ nmcli connection modify em1 connec but not at $ nmcli connection modify em1 connection.autoconnect Signed-off-by: Thomas Haller --- cli/completion/nmcli | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cli/completion/nmcli b/cli/completion/nmcli index 30497af814..e2aff2969b 100644 --- a/cli/completion/nmcli +++ b/cli/completion/nmcli @@ -822,7 +822,9 @@ _nmcli() words=("${words[@]:2}") OPTIONS=(id uuid path apath) _nmcli_complete_COMMAND_CONNECTION && return 0 - _nmcli_list_nl "$(nmcli connection show configured "${COMMAND_CONNECTION_TYPE:-id}" "$COMMAND_CONNECTION_ID" 2>/dev/null | sed -n 's/^\([^:]\+\):.*/\1/p')" + if [[ ${#words[@]} -le 1 ]]; then + _nmcli_list_nl "$(nmcli connection show configured "${COMMAND_CONNECTION_TYPE:-id}" "$COMMAND_CONNECTION_ID" 2>/dev/null | sed -n 's/^\([^:]\+\):.*/\1/p')" + fi fi ;; de|del|dele|delet|delete)