From 6199287b471a7df9e75835f7430fa705e91f7a55 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 23 Feb 2021 07:15:40 +0100 Subject: [PATCH] wwan: fix leaking "bearer" in connect_ready() Fixes: 105ee6e5a9aa ('device: fix crash by handling connection cancellation') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/669 (cherry picked from commit 5747bdb8b851a5c27868d4175b865a915d12549a) (cherry picked from commit 65e88671d6c774775d51ebeae6f54c228281ab47) (cherry picked from commit d26f17f24cbffd1f2149c50683725f14d68dc672) --- src/devices/wwan/nm-modem-broadband.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/devices/wwan/nm-modem-broadband.c b/src/devices/wwan/nm-modem-broadband.c index 0929adafc4..ad50d43eb5 100644 --- a/src/devices/wwan/nm-modem-broadband.c +++ b/src/devices/wwan/nm-modem-broadband.c @@ -358,7 +358,7 @@ connect_ready (MMModemSimple *simple_iface, GError *error = NULL; NMModemIPMethod ip4_method = NM_MODEM_IP_METHOD_UNKNOWN; NMModemIPMethod ip6_method = NM_MODEM_IP_METHOD_UNKNOWN; - MMBearer *bearer; + gs_unref_object MMBearer *bearer = NULL; bearer = mm_modem_simple_connect_finish (simple_iface, res, &error); @@ -372,7 +372,7 @@ connect_ready (MMModemSimple *simple_iface, if (!ctx) return; - self->_priv.bearer = bearer; + self->_priv.bearer = g_steal_pointer (&bearer); if (!self->_priv.bearer) { if (g_error_matches (error, MM_MOBILE_EQUIPMENT_ERROR, MM_MOBILE_EQUIPMENT_ERROR_SIM_PIN) ||