From 60be9cbc9e9d93aaa3e7e749a39434128ba2d81a Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 10 Nov 2016 10:03:59 +0100 Subject: [PATCH] device: fix memleak for ndisc_search->domain in ndisc_set_router_config() It is a bit fragile not to clone the string because we depend on nm_ip6_config_get_search(priv->ip6_config) to be stable. In practice, it's no problem. Saves an additional strdup and the effort to cleanup the memory afterwards. --- src/devices/nm-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index 2b494bb9b3..29c5049d5d 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -1875,7 +1875,7 @@ ndisc_set_router_config (NMNDisc *ndisc, NMDevice *self) NMNDiscDNSDomain *ndisc_search; ndisc_search = &g_array_index (dns_domains, NMNDiscDNSDomain, i); - ndisc_search->domain = g_strdup (search); + ndisc_search->domain = (char *) search; ndisc_search->timestamp = now; ndisc_search->lifetime = NM_NDISC_ROUTER_LIFETIME; }