From 60744889e22bec3fd03a59c66619294a9e0437f4 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 4 May 2021 22:58:13 +0200 Subject: [PATCH] firewall: fix adding duplicate iptables rules for shared mode nm_act_request_set_shared() already calls nm_utils_share_rules_apply(). Calling it twice, is pretty bad because during deactivate we will only remove one of each duplicate rule. Fixes: 701654b93064 ('core: refactor tracking of shared-rules to use NMUtilsShareRules') --- src/core/devices/nm-device.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c index 1a2fcb371e..6afecc2c51 100644 --- a/src/core/devices/nm-device.c +++ b/src/core/devices/nm-device.c @@ -11600,8 +11600,6 @@ start_sharing(NMDevice *self, NMIP4Config *config, GError **error) nm_utils_share_rules_add_all_rules(share_rules, ip_iface, ip4_addr->address, ip4_addr->plen); - nm_utils_share_rules_apply(share_rules, TRUE); - nm_act_request_set_shared(req, share_rules); conn = nm_act_request_get_applied_connection(req);