fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 07:38:20 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg-rh/trivial: add fixme comments about lossy write/read of properties

Browse source
This commit is contained in:
Thomas Haller 2022-04-04 17:41:33 +02:00
parent e9340c792c
commit 5f5641d304
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
View file

@ -397,7 +397,9 @@ write_8021x_setting(NMConnection *connection,
if (wired)
svSetValueStr(ifcfg, "KEY_MGMT", "IEEE8021X");
/* EAP method */
/* EAP method
*
* FIXME(ifcfg-full-cycle): persist all values of eap-method. */
if (nm_setting_802_1x_get_num_eap_methods(s_8021x)) {
value = nm_setting_802_1x_get_eap_method(s_8021x, 0);
if (value)
@ -455,8 +457,10 @@ write_8021x_setting(NMConnection *connection,
value = "allow-auth";
else if (strcmp(value, "3") == 0)
value = "allow-unauth allow-auth";
else
else {
/* FIXME(ifcfg-full-cycle): does not handle the value "0". */
value = NULL;
}
}
svSetValueStr(ifcfg, "IEEE_8021X_FAST_PROVISIONING", value);
@ -503,6 +507,8 @@ write_8021x_setting(NMConnection *connection,
str = g_string_new(NULL);
num = nm_setting_802_1x_get_num_altsubject_matches(s_8021x);
for (i = 0; i < num; i++) {
/* FIXME(ifcfg-full-cycle): this cannot handle values with spaces, which
* are not rejected by nm_connection_verify(). */
if (i > 0)
g_string_append_c(str, ' ');
match = nm_setting_802_1x_get_altsubject_match(s_8021x, i);
@ -515,6 +521,8 @@ write_8021x_setting(NMConnection *connection,
str = g_string_new(NULL);
num = nm_setting_802_1x_get_num_phase2_altsubject_matches(s_8021x);
for (i = 0; i < num; i++) {
/* FIXME(ifcfg-full-cycle): this cannot handle values with spaces, which
* are not rejected by nm_connection_verify(). */
if (i > 0)
g_string_append_c(str, ' ');
match = nm_setting_802_1x_get_phase2_altsubject_match(s_8021x, i);