fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-31 17:10:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform: assert for valid ifname in ethtool_get()

Browse source 
Add an assert (g_return_val_if_reached()) that the interface name is
valid and shorter then 16 bytes. If it happened to be longer, strncpy()
would not have zero terminated the interface name.
This commit is contained in:
Thomas Haller 2015-07-03 09:53:34 +02:00
parent 904e961464
commit 5b123f2539
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/platform/nm-platform-utils.c
View file

@ -48,8 +48,11 @@ ethtool_get (const char *name, gpointer edata)
if (!name || !*name)
return FALSE;
if (strlen (name) >= IFNAMSIZ)
g_return_val_if_reached (FALSE);
memset (&ifr, 0, sizeof (ifr));
strncpy (ifr.ifr_name, name, IFNAMSIZ);
strcpy (ifr.ifr_name, name);
ifr.ifr_data = edata;
fd = socket (PF_INET, SOCK_DGRAM, 0);