From 5b0396efc04cb2bd3e7fb885e3f5db11d4af0c35 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 30 Aug 2021 18:51:09 +0200 Subject: [PATCH] platform: don't set lp_advertising in set_link_settings_new() I don't understand why this was done. I don't think it's necessary nor correct. (cherry picked from commit 595099f27ad72221021d5dbc3ebaa8b3ad8288e2) --- src/libnm-platform/nm-platform-utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libnm-platform/nm-platform-utils.c b/src/libnm-platform/nm-platform-utils.c index 518e75bc7e..d95b106f89 100644 --- a/src/libnm-platform/nm-platform-utils.c +++ b/src/libnm-platform/nm-platform-utils.c @@ -1428,9 +1428,8 @@ set_link_settings_new(SocketHandle * shandle, edata->autoneg = AUTONEG_ENABLE; - /* copy @map_supported to @map_advertising and @map_lp_advertising */ memcpy(v_map_advertising, v_map_supported, sizeof(guint32) * nwords); - memcpy(v_map_lp_advertising, v_map_supported, sizeof(guint32) * nwords); + (void) v_map_lp_advertising; if (speed != 0) { guint32 mode; @@ -1457,7 +1456,6 @@ set_link_settings_new(SocketHandle * shandle, } v_map_advertising[0] = (v_map_advertising[0] & ~BASET_ALL_MODES) | mode; - v_map_lp_advertising[0] = v_map_advertising[0]; } } else { edata->autoneg = AUTONEG_DISABLE;