From 5a5e08794e93e3ec250648b7765bdff67c671bce Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 24 Sep 2019 18:27:37 +0200 Subject: [PATCH] libnm: drop unused NM_SETTING_PARAM_GENDATA_BACKED property flag The idea was that properties that are implemented via GENDATA still could have a GObject property. As such, they would be marked with this flag. Currently, gendata properties are only implemented by NMSettingEthtool, and there are no GObject properties where this flag is used. While it might make sense in theory or in the future, it is unused. Drop it. --- libnm-core/nm-setting-private.h | 2 -- libnm-core/nm-setting.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/libnm-core/nm-setting-private.h b/libnm-core/nm-setting-private.h index d4444039b7..0b7509d8c1 100644 --- a/libnm-core/nm-setting-private.h +++ b/libnm-core/nm-setting-private.h @@ -67,8 +67,6 @@ gboolean _nm_setting_clear_secrets (NMSetting *setting, */ #define NM_SETTING_PARAM_REAPPLY_IMMEDIATELY (1 << (6 + G_PARAM_USER_SHIFT)) -#define NM_SETTING_PARAM_GENDATA_BACKED (1 << (7 + G_PARAM_USER_SHIFT)) - extern const NMSettInfoPropertType nm_sett_info_propert_type_deprecated_interface_name; extern const NMSettInfoPropertType nm_sett_info_propert_type_deprecated_ignore_i; extern const NMSettInfoPropertType nm_sett_info_propert_type_deprecated_ignore_u; diff --git a/libnm-core/nm-setting.c b/libnm-core/nm-setting.c index 97e3441385..d4bd9bc764 100644 --- a/libnm-core/nm-setting.c +++ b/libnm-core/nm-setting.c @@ -590,9 +590,6 @@ property_to_dbus (const NMSettInfoSetting *sett_info, if (!NM_FLAGS_HAS (property->param_spec->flags, G_PARAM_WRITABLE)) return NULL; - if (NM_FLAGS_ANY (property->param_spec->flags, NM_SETTING_PARAM_GENDATA_BACKED)) - return NULL; - if ( NM_FLAGS_HAS (property->param_spec->flags, NM_SETTING_PARAM_LEGACY) && !_nm_utils_is_manager_process) return NULL;