fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-08 10:40:30 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

manager: fix memleak in system_hostname_changed_cb()

Browse source 
Also, no need to clone the hostname again.

Fixes: c9067d8fed
This commit is contained in:
Thomas Haller 2015-08-18 14:28:57 +02:00
parent d9c4411402
commit 58a2e99294
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/nm-manager.c
View file

@ -1091,18 +1091,26 @@ system_hostname_changed_cb (NMSettings *settings,
char *hostname;
hostname = nm_settings_get_hostname (priv->settings);
/* nm_settings_get_hostname() does not return an empty hostname. */
nm_assert (!hostname || *hostname);
if (!hostname && !priv->hostname)
return;
if (hostname && priv->hostname && !strcmp (hostname, priv->hostname))
if (hostname && priv->hostname && !strcmp (hostname, priv->hostname)) {
g_free (hostname);
return;
}
/* realloc, to free possibly trailing data after NUL. */
if (hostname)
hostname = g_realloc (hostname, strlen (hostname) + 1);
g_free (priv->hostname);
priv->hostname = (hostname && strlen (hostname)) ? g_strdup (hostname) : NULL;
priv->hostname = hostname;
g_object_notify (G_OBJECT (self), NM_MANAGER_HOSTNAME);
nm_dhcp_manager_set_default_hostname (nm_dhcp_manager_get (), priv->hostname);
g_free (hostname);
}
/*******************************************************************/