From 58704a37aed1b63bad68a85e93479d9d39f46448 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 23 May 2019 09:10:07 +0200 Subject: [PATCH] dispatcher: don't print debug messages of dispatcher in regular mode Previously, we would log several messages with level "debug" / g_info(). _LOG_R_D (request, "start running ordered scripts..."); _LOG_R_D (request, "new request (%u scripts)", request->scripts->len); _LOG_R_D (request, "completed: no scripts"); Note that this effectively logs a message for every event. I think that is to verbose and not suitable for regular logging. Only enable these messages if debug logging is enabled. As such, these debug level messsages now are enabled together with the trace level messages. --- dispatcher/nm-dispatcher.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dispatcher/nm-dispatcher.c b/dispatcher/nm-dispatcher.c index f1eb76bc61..4a36d225c5 100644 --- a/dispatcher/nm-dispatcher.c +++ b/dispatcher/nm-dispatcher.c @@ -169,17 +169,18 @@ struct Request { } G_STMT_END static gboolean -_LOG_R_T_enabled (const Request *request) +_LOG_R_D_enabled (const Request *request) { return request->debug; } +#define _LOG_R_T_enabled(request) _LOG_R_D_enabled (request) #define _LOG_R_T(_request, ...) _LOG(_request, NULL, FALSE, g_debug, __VA_ARGS__) -#define _LOG_R_D(_request, ...) _LOG(_request, NULL, TRUE, g_info, __VA_ARGS__) +#define _LOG_R_D(_request, ...) _LOG(_request, NULL, FALSE, g_info, __VA_ARGS__) #define _LOG_R_W(_request, ...) _LOG(_request, NULL, TRUE, g_warning, __VA_ARGS__) #define _LOG_S_T(_script, ...) _LOG(NULL, _script, FALSE, g_debug, __VA_ARGS__) -#define _LOG_S_D(_script, ...) _LOG(NULL, _script, TRUE, g_info, __VA_ARGS__) +#define _LOG_S_D(_script, ...) _LOG(NULL, _script, FALSE, g_info, __VA_ARGS__) #define _LOG_S_W(_script, ...) _LOG(NULL, _script, TRUE, g_warning, __VA_ARGS__) /*****************************************************************************/