From 57e2f76f57d8368ab3318f14d9131c3f63ce235f Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 30 Jan 2020 11:39:35 +0100 Subject: [PATCH] supplicant: fix memory corruption with wrong argument to NM_SUPPLICANT_INTERFACE_GROUP_FORMATION_FAILURE signal The signal is unused (and should be removed). Still, the parameter passed to g_signal_emit() is a C string, not a GVariant. I think as there are no subscribers, glib wouldn't actually do anything with the arguments. Though, I am not sure whether glib still tries to initialize a GValue with a GVariant type, leading to a crash. Fixes: f05b7a78c9aa ('supplicant: Track P2P Group information, creation and destruction') (cherry picked from commit c1060080913e16a101c955ee69298ecf1c6452d3) (cherry picked from commit 26d6ac53857a2fe705fd50bc2751ae53fd26f134) (cherry picked from commit dc9322c0a96544f8e91b79e6e8956c7961a858d3) --- src/supplicant/nm-supplicant-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/supplicant/nm-supplicant-interface.c b/src/supplicant/nm-supplicant-interface.c index 12d21aba44..8649b24efe 100644 --- a/src/supplicant/nm-supplicant-interface.c +++ b/src/supplicant/nm-supplicant-interface.c @@ -2981,5 +2981,5 @@ nm_supplicant_interface_class_init (NMSupplicantInterfaceClass *klass) G_SIGNAL_RUN_LAST, 0, NULL, NULL, NULL, - G_TYPE_NONE, 1, G_TYPE_VARIANT); + G_TYPE_NONE, 1, G_TYPE_STRING); }