fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-24 10:10:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/logging: define nm_log() to check for nm_logging_enabled() first

Browse source 
Change the definition of nm_log() to first check whether logging is
enabled. This has the benefit, that the logging arguments don't have
to be evaluated if logging is disabled.

With this change, you must ensure, that calling any logging function
is side-effect-free. For example:
    nm_log_debug ("This is a bug %s, %d", has_side_effect (), ++i);
would be a bug, because the logging arguments get only evaluated
depending on the logging setup.

Signed-off-by: Thomas Haller <thaller@redhat.com>
This commit is contained in:
Thomas Haller 2014-02-12 11:44:12 +01:00
parent 7509d4f80f
commit 573576bedd
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/nm-logging.h
View file

@ -97,8 +97,14 @@ GQuark nm_logging_error_quark (void);
#define nm_log_info(domain, ...) nm_log (LOGL_INFO, (domain), __VA_ARGS__)
#define nm_log_dbg(domain, ...) nm_log (LOGL_DEBUG, (domain), __VA_ARGS__)
/* nm_log() only evaluates it's argument list after checking
* whether logging for the given level/domain is enabled. */
#define nm_log(level, domain, ...) \
_nm_log (G_STRLOC, G_STRFUNC, (level), (domain), __VA_ARGS__)
G_STMT_START { \
if (nm_logging_enabled ((level), (domain))) { \
_nm_log (G_STRLOC, G_STRFUNC, (level), (domain), __VA_ARGS__); \
} \
} G_STMT_END
void _nm_log (const char *loc,
const char *func,