From 5458b36bfc29a25dca110b8af8aed579d8888716 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 15 Jun 2017 21:16:42 +0200 Subject: [PATCH] libnm: remove property getter for NMObject's "dbus-object" and "dbus-object-manager" These properties are internal and shall not be publicly accessible. Remove the getter. We may later no longer use GDBusObjectManager. It should be an implementation detail, not exposed in the public API of NMObject. (cherry picked from commit 357fd6ba822a23297325d2c87b8f8a6daabcb790) --- libnm/nm-object.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libnm/nm-object.c b/libnm/nm-object.c index 95346e06e9..6bf1d0636d 100644 --- a/libnm/nm-object.c +++ b/libnm/nm-object.c @@ -1233,12 +1233,6 @@ get_property (GObject *object, guint prop_id, case PROP_DBUS_CONNECTION: g_value_set_object (value, g_dbus_object_manager_client_get_connection (G_DBUS_OBJECT_MANAGER_CLIENT (priv->object_manager))); break; - case PROP_DBUS_OBJECT: - g_value_set_object (value, priv->object); - break; - case PROP_DBUS_OBJECT_MANAGER: - g_value_set_object (value, priv->object_manager); - break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); break; @@ -1335,7 +1329,7 @@ nm_object_class_init (NMObjectClass *nm_object_class) (object_class, PROP_DBUS_OBJECT, g_param_spec_object (NM_OBJECT_DBUS_OBJECT, "", "", G_TYPE_DBUS_OBJECT, - G_PARAM_READWRITE | + G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS)); @@ -1348,7 +1342,7 @@ nm_object_class_init (NMObjectClass *nm_object_class) (object_class, PROP_DBUS_OBJECT_MANAGER, g_param_spec_object (NM_OBJECT_DBUS_OBJECT_MANAGER, "", "", G_TYPE_DBUS_OBJECT_MANAGER, - G_PARAM_READWRITE | + G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY | G_PARAM_STATIC_STRINGS)); }