From 53db3a2da901bbcbc7e3c64e52ac7bc76324c561 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thaller@redhat.com>
Date: Tue, 3 Dec 2019 14:50:12 +0100
Subject: [PATCH] libnm: don't emit property changed "notify" signal while
 destructing NMClient

It seems to trip up gnome-control-center (rh #1778668). Just don't emit
anymore signals once NMClient goes down.
---
 libnm/nm-client.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libnm/nm-client.c b/libnm/nm-client.c
index 05ccdac3fa..1a1ed25694 100644
--- a/libnm/nm-client.c
+++ b/libnm/nm-client.c
@@ -735,6 +735,14 @@ _nm_client_queue_notify_object (NMClient *self,
 	nm_assert (NM_IS_OBJECT (nmobj) || NM_IS_CLIENT (nmobj));
 
 	base = (NMObjectBase *) nmobj;
+
+	if (base->is_disposing) {
+		/* Don't emit property changed signals once the NMClient
+		 * instance is about to shut down. */
+		nm_assert (nmobj == self);
+		return;
+	}
+
 	if (c_list_is_empty (&base->queue_notify_lst)) {
 		c_list_link_tail (&NM_CLIENT_GET_PRIVATE (self)->queue_notify_lst_head,
 		                  &base->queue_notify_lst);