all: drop lgtm annotations

lgtm is going away. These annotations are no longer useful.

https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/

.lgtm.yml

@@ -1,57 +0,0 @@
-# Configuration for https://lgtm.com
-
-extraction:
-  cpp:
-     prepare:
-        packages:
-          - autoconf
-          - automake
-          - autopoint
-          - clang
-          - dbus
-          - dbus-x11
-          - dnsmasq
-          - git
-          - gobject-introspection
-          - gtk-doc-tools
-          - intltool
-          - iproute2
-          - iptables
-          - libaudit-dev
-          - libcurl4-gnutls-dev
-          - libdbus-1-dev
-          - libgirepository1.0-dev
-          - libglib2.0-dev
-          - libglib2.0-doc
-          - libgnutls28-dev
-          - libiw-dev
-          - libjansson-dev
-          - libjansson4
-          - libmm-glib-dev
-          - libndp-dev
-          - libnewt-dev
-          - libnss3-dev
-          - libpolkit-gobject-1-dev
-          - libreadline-dev
-          - libsystemd-dev
-          - libteam-dev
-          - libtool
-          - libudev-dev
-          - locales
-          - make
-          - meson
-          - mobile-broadband-provider-info
-          - pkg-config
-          - ppp
-          - ppp-dev
-          - python-dbus
-          - python-gi
-          - python-setuptools
-          - python3-dbus
-          - python3-gi
-          - python3-pip
-          - python3-setuptools
-          - udev
-     configure:
-        command:
-        - ./autogen.sh

src/libnm-base/nm-ethtool-utils-base.h

@@ -3,7 +3,7 @@
  * Copyright (C) 2018 Red Hat, Inc.
  */
 
-#ifndef __NM_ETHTOOL_UTILS_H__ /* lgtm[cpp/duplicate-include-guard] */
+#ifndef __NM_ETHTOOL_UTILS_H__
 #define __NM_ETHTOOL_UTILS_H__
 
 G_BEGIN_DECLS

src/libnm-client-public/nm-ethtool-utils.h

@@ -3,7 +3,7 @@
  * Copyright (C) 2018 Red Hat, Inc.
  */
 
-#ifndef __NM_ETHTOOL_UTILS_H__ /* lgtm[cpp/duplicate-include-guard] */
+#ifndef __NM_ETHTOOL_UTILS_H__
 #define __NM_ETHTOOL_UTILS_H__
 
 G_BEGIN_DECLS

src/libnm-core-impl/nm-setting-wireguard.c

@@ -1857,9 +1857,7 @@ clear_secrets(const NMSettInfoSetting         *sett_info,
                 if (j++ < 5) {
                     /* we use alloca() inside a loop here, but it is guarded to happen at most
                      * a few times. */
-                    name = peers_psk_get_secret_name_a(/* lgtm [cpp/alloca-in-loop] */
-                                                       peer->public_key,
-                                                       &name_free);
+                    name = peers_psk_get_secret_name_a(peer->public_key, &name_free);
                 } else {
                     name_free = peers_psk_get_secret_name_dup(peer->public_key);
                     name      = name_free;

src/libnmc-setting/nm-meta-setting-desc.c

@@ -126,11 +126,7 @@ _value_str_as_index_list(const char *value, gsize *out_len)
             if (!str_cloned) {
                 /* we use alloca() inside a loop here, but it is guarded to happen at most once. */
                 str_cloned = TRUE;
-                str        = nm_strndup_a(/* lgtm [cpp/alloca-in-loop] */
-                                   200,
-                                   str,
-                                   strlen(str),
-                                   &str_clone_free);
+                str        = nm_strndup_a(200, str, strlen(str), &str_clone_free);
             }
             s         = str;
             str[good] = '\0';