From 519ea3f0d47de648743ed693d8bf649bd0768d14 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 25 Jun 2015 15:36:43 +0200 Subject: [PATCH] libnm-keyfile: ensure g_key_file_get_groups() sets the length argument Under certain cases, if g_key_file_get_groups() fails, it might not set the out argument @length. Play it safe and initialize it. (cherry picked from commit aa7a53bc67acbaa299565f5d64d33f0ca9584a3a) --- libnm-core/nm-keyfile-reader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libnm-core/nm-keyfile-reader.c b/libnm-core/nm-keyfile-reader.c index df568a8ebd..353804f97c 100644 --- a/libnm-core/nm-keyfile-reader.c +++ b/libnm-core/nm-keyfile-reader.c @@ -1577,6 +1577,8 @@ nm_keyfile_read (GKeyFile *keyfile, info.user_data = user_data; groups = g_key_file_get_groups (keyfile, &length); + if (!groups) + length = 0; for (i = 0; i < length; i++) { /* Only read out secrets when needed */ if (!strcmp (groups[i], VPN_SECRETS_GROUP)) {