fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-06-10 05:38:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

dhcp/dhclient: validate hostname before pasting it into dhclient config

Browse source
This commit is contained in:
Jan Vaclav 2026-06-09 11:28:15 +02:00
parent 2cc705a154
commit 4ee290c662
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/core/dhcp/nm-dhcp-dhclient-utils.c
View file

@ -39,6 +39,21 @@
#define MUDURLv6_DEF "option dhcp6.mudurl code 112 = text;\n"
#define MUDURLv6_FMT "send dhcp6.mudurl \"%s\";\n"
static gboolean
_dhclient_hostname_is_valid(const char *s)
{
for (const char *p = s; *p; p++) {
if (*p == '"' || *p == '\\' || *p < 0x20) {
nm_log_warn(
LOGD_DHCP,
"hostname '%s' contains unsafe characters for dhclient config, will be ignored",
s);
return FALSE;
}
}
return TRUE;
}
static void
add_request(GPtrArray *array, const char *item)
{
@ -140,7 +155,7 @@ add_ip4_config(GString *str,
g_string_append(str, "; # added by NetworkManager\n");
}
if (hostname) {
if (hostname && _dhclient_hostname_is_valid(hostname)) {
if (use_fqdn) {
g_string_append_printf(str, FQDN_FORMAT "\n", hostname);
@ -179,7 +194,7 @@ add_ip4_config(GString *str,
static void
add_hostname6(GString *str, const char *hostname, NMDhcpHostnameFlags hostname_flags)
{
if (hostname) {
if (hostname && _dhclient_hostname_is_valid(hostname)) {
g_string_append_printf(str, FQDN_FORMAT "\n", hostname);
if (hostname_flags & NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE)
g_string_append(str, FQDN_TAG_PREFIX "server-update on;\n");