From 4e7eadd6d3425f301277448329d53e93b09236b9 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 19 Mar 2019 20:28:44 +0100 Subject: [PATCH] cli: fix appending team link-watchers The set_fcn() function is supposed to only append. For the set-all mode, the caller ensures to clear the array first. --- clients/common/nm-meta-setting-desc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index 6e35228ad6..838661c2e4 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -4144,7 +4144,6 @@ _set_fcn_team_link_watchers (ARGS_SET_FCN) const char *const*iter; NMTeamLinkWatcher *watcher; - nm_setting_team_clear_link_watchers (NM_SETTING_TEAM (setting)); strv = nm_utils_strsplit_set (value, ",", FALSE); for (iter = strv; strv && *iter; iter++) { watcher = _parse_team_link_watcher (*iter, error); @@ -4218,7 +4217,6 @@ _set_fcn_team_port_link_watchers (ARGS_SET_FCN) const char *const*iter; NMTeamLinkWatcher *watcher; - nm_setting_team_port_clear_link_watchers (NM_SETTING_TEAM_PORT (setting)); strv = nm_utils_strsplit_set (value, ",", FALSE); for (iter = strv; strv && *iter; iter++) { watcher = _parse_team_link_watcher (*iter, error);